Fix: Variable name #476
Draft
Fix: Variable name #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhdbsrlw
requested review from
awaelchli,
carmocca and
lantiga
as code owners
rasbt
reviewed
Aug 22, 2024
| Checks the width of the lm_head.weight matrix, as these uniquely identify the model. | ||
| """ | ||
| embedding_size = checkpoint['transformer.wte.weight'].shape[1] | ||
| embedding_size = checkpoint['lm_head.weight'].shape[1] |
Contributor
There was a problem hiding this comment.
I think the original key should exist for the original Llama weights. Maybe you downloaded the weights from somewhere else? Perhaps the following would be a good compromise:
Suggested change
| embedding_size = checkpoint['lm_head.weight'].shape[1] | |
| if 'transformer.wte.weight' in checkpoint: | |
| embedding_size = checkpoint['transformer.wte.weight'].shape[1] | |
| elif 'lm_head.weight' in checkpoint: | |
| embedding_size = checkpoint['lm_head.weight'].shape[1] | |
| else: | |
| raise ValueError("Neither 'transformer.wte.weight' nor 'lm_head.weight' found in the checkpoint") |
rasbt
suggested changes
Aug 22, 2024
Contributor
rasbt
left a comment
rasbt
left a comment
There was a problem hiding this comment.
Can't reproduce it at the moment but perhaps we can have a compromise here that remains backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I think variable's name should be changed in 'lit_llama/utils.py.'
When I implement your code, the existing code causes error. Then I debugged with printing.
There was no key named 'transformer.wte.weight' in checkpoint.
Thank you.